[PATCH] Revert "winealsa.drv: Send MIDI events to port subscribers."

Andrew Eikum aeikum at codeweavers.com
Thu Dec 16 10:25:09 CST 2021


On Thu, Dec 16, 2021 at 11:21:11PM +0900, Masanori Kakura wrote:
> This reverts commit 3d57cc2863f2f9a5ace40d29317b3ff4357fd119.
> 
> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52220
> Signed-off-by: Masanori Kakura <kakurasan at gmail.com>

Thanks for reporting and looking into this, Kakurasan.

Jacek, this patch was sent by you. Can you take a look at this bug and
give us your thoughts?

Thank you,
Andrew

> ---
>  dlls/winealsa.drv/midi.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/dlls/winealsa.drv/midi.c b/dlls/winealsa.drv/midi.c
> index 073c0a6e3f3..74512ad09d2 100644
> --- a/dlls/winealsa.drv/midi.c
> +++ b/dlls/winealsa.drv/midi.c
> @@ -869,7 +869,7 @@ static DWORD modData(WORD wDevID, DWORD dwParam)
>              snd_seq_ev_clear(&event);
>              snd_seq_ev_set_direct(&event);
>              snd_seq_ev_set_source(&event, port_out);
> -            snd_seq_ev_set_subs(&event);
> +            snd_seq_ev_set_dest(&event, MidiOutDev[wDevID].addr.client, MidiOutDev[wDevID].addr.port);
>  	    
>  	    switch (evt & 0xF0) {
>  	    case MIDI_CMD_NOTE_OFF:
> @@ -1038,7 +1038,8 @@ static DWORD modLongData(WORD wDevID, LPMIDIHDR lpMidiHdr, DWORD dwSize)
>  	snd_seq_ev_clear(&event);
>  	snd_seq_ev_set_direct(&event);
>  	snd_seq_ev_set_source(&event, port_out);
> -	snd_seq_ev_set_subs(&event);
> +	snd_seq_ev_set_dest(&event, MidiOutDev[wDevID].addr.client, MidiOutDev[wDevID].addr.port);
> +	TRACE("destination %d:%d\n", MidiOutDev[wDevID].addr.client, MidiOutDev[wDevID].addr.port);
>  	snd_seq_ev_set_sysex(&event, lpMidiHdr->dwBufferLength + len_add, lpNewData ? lpNewData : lpData);
>          EnterCriticalSection(&midiSeqLock);
>  	snd_seq_event_output_direct(midiSeq, &event);
> -- 
> 2.32.0
> 
> 



More information about the wine-devel mailing list