[PATCH vkd3d v2 4/4] vkd3d: Move atomic descriptor operations behind a config option.

Conor McCarthy cmccarthy at codeweavers.com
Fri Dec 17 00:47:51 CST 2021


December 16, 2021 7:05 PM, "Henri Verbeet" <hverbeet at gmail.com> wrote:

> Could we just lock all of them pre-emptively? There are only 8; in
> theory we'd be ahead after copying more than that number of
> descriptors, in terms of locking overhead at least.

Performance in SotTR was dismal after adding that to optimised copying, so the game probably doesn't copy very many per call or it has a bunch of other writes going at the same time.

> We could also consider moving to a single mutex for descriptor
> updates. IIRC the current scheme was introduced for Shadow of the Tomb
> Raider, but it seems we no longer care about that application as
> much...

Performance is not bad with a single mutex combined with optimised copies. It's still roughly 3 ms slower per frame, but yes SotTR performance is not a priority.



More information about the wine-devel mailing list