[PATCH vkd3d 4/6] vkd3d-shader/hlsl: Write SM4 greater-than instructions.

Giovanni Mascellani gmascellani at codeweavers.com
Fri Dec 17 14:40:40 CST 2021


Hi,

On 17/12/21 19:07, Zebediah Figura (she/her) wrote:
> Should we lower these at parse time instead?
> 
> Same for LE -> GE.

Don't know. I have to say that I was genuinely surprised that we allowed 
so much redundancy in the IR, but certainly it won't be me the one who 
complains about having an expressive IR. So, given that it had already 
been accepted, I didn't protest.

My feeling is that when your compiler isn't able to handle most trivial 
arithmetic operators it is a bit early to enter fine discussions about 
how to best trim the IR so that optimization phases that do not exist 
yet might be a little bit better or not.

Giovanni.



More information about the wine-devel mailing list