[PATCH] mshtml: Avoid null pointer dereference in OmHistory_get_length (cppcheck)

Alex Henrie alexhenrie24 at gmail.com
Sun Dec 19 22:54:37 CST 2021


Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
---
 dlls/mshtml/omnavigator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/mshtml/omnavigator.c b/dlls/mshtml/omnavigator.c
index 70e8e568661..7788b453b8d 100644
--- a/dlls/mshtml/omnavigator.c
+++ b/dlls/mshtml/omnavigator.c
@@ -674,7 +674,7 @@ static HRESULT WINAPI OmHistory_get_length(IOmHistory *iface, short *p)
     if(This->window && This->window->base.outer_window)
         browser = This->window->base.outer_window->browser;
 
-    *p = browser->doc->travel_log
+    *p = browser && browser->doc->travel_log
         ? ITravelLog_CountEntries(browser->doc->travel_log, browser->doc->browser_service)
         : 0;
     return S_OK;
-- 
2.34.1




More information about the wine-devel mailing list