[PATCH 1/3] concrt140: Add ?_Byte_reverse_table at details@Concurrency@@3QBEB data export.

[Paul Gofman]

On 12/20/21 19:08, Piotr Caban wrote:
> Hi Paul,
>
> The patch looks good to me. I'm not sure if it's good for code freeze 
> but it looks like a low risk change. I guess that Halo Infinite was 
> never working in vanilla wine.
>
> When introducing detals.c file copy in concrt140 the idea was to keep 
> the files as similar as possible (currently there's only change in one 
> include + _MSVCP_VER define is not present in concrt). Could you 
> please add the table in the same place both in concrt140 and msvcp90?
>
> Please also update msvcp120_app.spec file.
>
> Thanks,
> Piotr

Thanks, I will update that. I just discovered however that the reason it 
worked before for me was only because the native library was used. With 
the builtin it needs more with the next being 
??0_Concurrent_queue_iterator_base_v4 at details@Concurrency@@IEAA at AEBV_Concurrent_queue_base_v4@12@@Z 
(probably other iterator details to follow at least).

So could you pleas advise what is the best for now, finish the data 
export once started or leave until the code freeze end?