[PATCH vkd3d 02/13] vkd3d-shader/hlsl: Pass copy_propagation_state and hlsl_deref pointers to copy_propagation_compute_replacement().

Giovanni Mascellani gmascellani at codeweavers.com
Wed Dec 22 03:23:26 CST 2021


Hi,

On 22/12/21 00:08, Zebediah Figura wrote:
> @@ -377,10 +385,15 @@ static struct hlsl_ir_node *copy_propagation_compute_replacement(struct copy_pro
>           if (!node)
>               node = var_def->values[offset + i].node;
>           else if (node != var_def->values[offset + i].node)
> +        {
> +            TRACE("No single source for propagating load from %s[%u-%u].\n", var->name, offset, offset + count);
>               return NULL;
> +        }

That's fine for me, but I guess that usually vkd3d's policy is that if 
one branch of an "if ... else if ... else" chain has braces, then all of 
them must have. Or did I misunderstand it?

Giovanni.



More information about the wine-devel mailing list