[PATCH] mfplat/tests: Print an error if the first call to get_event fails in test_source_resolver (Coverity)

Nikolay Sivov nsivov at codeweavers.com
Mon Dec 27 00:44:59 CST 2021



On 12/27/21 02:11, Alex Henrie wrote:
> -    video_stream = NULL;
> -    if (get_event((IMFMediaEventGenerator *)mediasource, MENewStream, &var))
> -    {
> -        ok(var.vt == VT_UNKNOWN, "Unexpected value type.\n");
> -        video_stream = (IMFMediaStream *)var.punkVal;
> -    }
> +    ret = get_event((IMFMediaEventGenerator *)mediasource, MENewStream, &var);
> +    ok(ret, "Failed to get event.\n");
> +    ok(var.vt == VT_UNKNOWN, "Unexpected value type.\n");
> +    video_stream = (IMFMediaStream *)var.punkVal;
The point is that if it's not MENewStream, you won't necessarily have 
IMFMediaStream in event data.



More information about the wine-devel mailing list