[PATCH 2/2] ole32: Fix memory leak on error path in composite_get_(left|right)most (Coverity)

Alex Henrie alexhenrie24 at gmail.com
Tue Dec 28 21:59:27 CST 2021


Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
---
 dlls/ole32/compositemoniker.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/dlls/ole32/compositemoniker.c b/dlls/ole32/compositemoniker.c
index 05901bb52b3..c234f60f953 100644
--- a/dlls/ole32/compositemoniker.c
+++ b/dlls/ole32/compositemoniker.c
@@ -1627,6 +1627,7 @@ static HRESULT composite_get_rightmost(CompositeMonikerImpl *composite, IMoniker
     if (!(node = moniker_tree_get_rightmost(root)))
     {
         WARN("Couldn't get right most component.\n");
+        moniker_tree_release(root);
         return E_FAIL;
     }
 
@@ -1663,6 +1664,7 @@ static HRESULT composite_get_leftmost(CompositeMonikerImpl *composite, IMoniker
     if (!(node = moniker_tree_get_leftmost(root)))
     {
         WARN("Couldn't get right most component.\n");
+        moniker_tree_release(root);
         return E_FAIL;
     }
 
-- 
2.34.1




More information about the wine-devel mailing list