[PATCH 1/4] winemenubuilder: Reuse buffer in wchars_to_xml_text (Coverity)

Alex Henrie alexhenrie24 at gmail.com
Tue Dec 28 22:14:08 CST 2021


Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
---
 programs/winemenubuilder/winemenubuilder.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/programs/winemenubuilder/winemenubuilder.c b/programs/winemenubuilder/winemenubuilder.c
index 16dc32a8859..620086f9776 100644
--- a/programs/winemenubuilder/winemenubuilder.c
+++ b/programs/winemenubuilder/winemenubuilder.c
@@ -319,7 +319,9 @@ static char *wchars_to_xml_text(const WCHAR *string)
 {
     int i, pos;
     char *text = wchars_to_utf8_chars( string );
-    char *ret = xmalloc( 6 * strlen(text) + 1 );
+    static char *ret;
+
+    ret = xrealloc( ret, 6 * strlen(text) + 1 );
 
     for (i = pos = 0; text[i]; i++)
     {
-- 
2.34.1




More information about the wine-devel mailing list