[PATCH] conhost: Fix status for READ_CONSOLE ioctl

Keno Fischer keno at juliacomputing.com
Wed Dec 29 11:03:23 CST 2021


Hi Jacek,

On Wed, Dec 29, 2021 at 11:13 AM Jacek Caban <jacek at codeweavers.com> wrote:
> process_console_input() generally handles 0 record_count, what's exactly
> wrong there? Does the attached patch help?

Yes, that patch would have a similar effect, except that I believe it
would still return STATUS_SUCCESS rather than STATUS_PENDING.
Unfortunately, I can't reproduce the exact issue I saw that caused
this right now (I upgraded my local tree from rc1 to master yesterday,
so that's likely the difference), but basically what I was seeing is that
conhost spammed about 100 or so unnecessary cursor
moves from inside `update_read_output`. That caused lots of blinking
in the terminal. This patch fixed that for me.

Keno



More information about the wine-devel mailing list