[PATCH] shell32: IPersistFile::Save(NULL) should use previously stored file name.

Huw Davies huw at codeweavers.com
Wed Feb 3 06:40:31 CST 2021


On Wed, Feb 03, 2021 at 02:20:46PM +0300, Dmitry Timoshkov wrote:
> Hi Huw,
> 
> Huw Davies <huw at codeweavers.com> wrote:
> 
> > On Wed, Feb 03, 2021 at 12:47:12PM +0300, Dmitry Timoshkov wrote:
> > > Dmitry Timoshkov <dmitry at baikal.ru> wrote:
> > > 
> > > > This is a resend, previous version didn't get much attention.
> > > 
> > > Is it possible to get a review of this patch, please?
> > 
> > What happens if you call IPersistFile_Save() with a NULL file before
> > a "remembered" save?
> 
> Thanks for the review. In that case ::Save() returns S_OK. I'll send another
> version of the patch with that fixed.

That's an interesting choice they made there.  I've sent in a v4
with some added IsDirty checks.

Huw.



More information about the wine-devel mailing list