[PATCH v2] gdi32/tests: Add tests for the advanced graphics mode

[Huw Davies]

On Tue, Feb 09, 2021 at 12:04:25PM +0100, Francois Gouget wrote:
> On Tue, 9 Feb 2021, Ralf Habacker wrote:
> 
> > Because drawing simple lines already gives different results than a
> > native Windows, the comparison of hashes does not work anymore.
> > 
> > Therefore, the tests associated to advanced graphics mode creates
> > bitmap files for each processed test in the current directoy, which
> > can then be compared visually.
> 
> It looks like this is a prime candidate for winetest_interactive:
> 
> if (winetest_interactive)
> {
>    /* Tests that require a human to check the results */
>    ...
> }
> 
> So to get the bitmaps to compare one would run the test with 
> set WINETEST_INTERACTIVE=1.
> 

You'd be better off testing simple cases (like rotations that
are a multiples of pi/2, or possibly pi/4) that should be
possible to match Windows exactly.  That way any regressions
will get caught.

Dumping to a bitmap is fine for testing, but nobody is going
to looking at them going forward.

You should append the tests to (the admittedly long)
draw_graphics(), they'll them get tested on a large number
of different bitmap formats.

Huw.