[PATCH v2 3/4] widl: Support partially specialized parameterized type.

[Rémi Bernon]

On 2/11/21 6:13 PM, Jacek Caban wrote:
> Hi Rémi,
> 
> On 11.02.2021 17:37, Rémi Bernon wrote:
>> +parameterized_type: qualified_type '<' parameterized_types '>'
>> +                        { $$ = find_parameterized_type($1, $3); }
>> +    ;
>> +
>> +parameterized_types:
>> +      base_type                { $$ = append_type(NULL, $1); }
>> +    | qualified_type            { $$ = append_type(NULL, $1); }
>> +    | qualified_type '*'            { $$ = append_type(NULL, 
>> type_new_pointer($1)); }
>> +    | parameterized_type            { $$ = append_type(NULL, $1); }
>> +    | parameterized_type '*'        { $$ = append_type(NULL, 
>> type_new_pointer($1)); }
>> +    | parameterized_types ',' parameterized_types
>> +                        { $$ = append_types($1, $3); }
>> +    ;
> 
> 
> Naming here is a bit unfortunate, in my opinion. I'd expect 
> parameterized_types to be a list of parameterized_type or something like 
> that, but it's quite not how it's used. I already got it wrong while 
> this reading the patch, so it would be great to make it cleaner.
> 
> 
> Thanks,
> 
> Jacek
> 

Right, I'll try to find something better.
-- 
Rémi Bernon <rbernon at codeweavers.com>