[PATCH v8] gdi32/tests: Add tests for the advanced graphics mode

Ralf Habacker ralf.habacker at freenet.de
Tue Feb 16 09:57:12 CST 2021


Am 10.02.21 um 11:40 schrieb Huw Davies:
> On Wed, Feb 10, 2021 at 11:02:49AM +0100, Ralf Habacker wrote:
>> The tests are designed to support an automated mode and an interactive
>> mode.
>>
>> In automated mode, only tests where the angle used is a multiple of pi/4
>> are performed to increase the chance of matching images created on Windows.
>>
>> In interactive test mode, an image is generated for each test for visual
>> verification.
> 
> Do you have plans to work on the implementation fixes?

yes

> It's probably better to start with that and then write specific
> tests that are easy to get the implementation correct for.

I have a working patch, which fixes issues for Arc, Chord, Ellipse and
Pie (see appended screenshots)

> Adding random tests at this point will likely make the fixing
> the implementation harder

I removed all not working tests from the automatic mode with v9.

Ralf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gdi32-dib-advanced-current.png
Type: image/png
Size: 100276 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20210216/70cc9e10/attachment-0002.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gdi32-dib-advanced-with-patch.png
Type: image/png
Size: 118011 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20210216/70cc9e10/attachment-0003.png>


More information about the wine-devel mailing list