[PATCH] vkd3d-shader: Set default case the last one in shader_sm4_read_param().

Chris Robinson chris.kcat at gmail.com
Sat Feb 20 06:36:03 CST 2021


On Sat, 20 Feb 2021 14:22:51 +0200
Andrey Gusev <andrey.goosev at gmail.com> wrote:

This changes behavior (*modifier is not being set anymore). A better
way to silence the warning may be to annotate the fall-through, like
this:

    default:
        FIXME("Skipping modifier 0x%08x.\n", m);
        /* fall-through */
    case VKD3D_SM4_REGISTER_MODIFIER_NONE:
        *modifier = VKD3DSPSM_NONE;
        break;

(at least in my experience, GCC and Clang recognize a comment like that
and suppress the implicit fall through warning).



More information about the wine-devel mailing list