[PATCH] winegstreamer: Fully initialize MF object creation context.

Nikolay Sivov nsivov at codeweavers.com
Mon Feb 22 12:32:47 CST 2021


Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
---

Problematic field is 'url' which is only set on string duplication. Uninitialize pointer
then appears in traces like this:

0230:trace:mfplat:winegstreamer_stream_handler_create_object (0x2b3915e0 L"\8507\1829\8120" 0x2e1ea458 1 (nil) 0x4c9dfaf0 0x4c9dfae8)

and later is passed to heap_free().

 dlls/winegstreamer/media_source.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/winegstreamer/media_source.c b/dlls/winegstreamer/media_source.c
index 32b4477ad88..caf1895a68c 100644
--- a/dlls/winegstreamer/media_source.c
+++ b/dlls/winegstreamer/media_source.c
@@ -1383,7 +1383,7 @@ static HRESULT WINAPI winegstreamer_stream_handler_BeginCreateObject(IMFByteStre
     if (FAILED(hr = MFCreateAsyncResult(NULL, callback, state, &caller)))
         return hr;
 
-    context = heap_alloc(sizeof(*context));
+    context = heap_alloc_zero(sizeof(*context));
     if (!context)
     {
         IMFAsyncResult_Release(caller);
-- 
2.30.0




More information about the wine-devel mailing list