[PATCH] ddraw: Show the window and change its topmost style when changing exclusive cooperative mode.

[Henri Verbeet]

On Tue, 12 Jan 2021 at 15:35, Gabriel Ivăncescu <gabrielopcode at gmail.com> wrote:
>
> On 12/01/2021 16:04, Henri Verbeet wrote:
> > On Tue, 12 Jan 2021 at 14:49, Gabriel Ivăncescu <gabrielopcode at gmail.com> wrote:
> >>
> >> Fixes a regression introduced by f90d607c67768f19e36d9d74b498594252faa3fd.
> >>
> >> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50370
> >> Signed-off-by: Gabriel Ivăncescu <gabrielopcode at gmail.com>
> >
> > I don't think this is correct.
> >
>
> I'm not terribly familiar with wined3d code, though I suspect you
> probably want to do it on that side somewhere. Do you have a better idea?
>
> Note that even changing from a EXCLUSIVE | NOWINDOWCHANGES to simply
> EXCLUSIVE will trigger the windowing change (show + topmost), so it's
> not done just when going from normal to exclusive.

Fundamentally, it looks like setting
WINED3D_SWAPCHAIN_NO_WINDOW_CHANGES without DDSCL_NOWINDOWCHANGES in
f90d607c67768f19e36d9d74b498594252faa3fd was simply wrong. The
behaviour of not showing the window if a different window is the
active window also happens with Direct3D 9. Where it differs from
DirectDraw is how it behaves for cases where GetActiveWindow() would
return NULL.