[PATCH] gdi32: Avoid dereferencing NULL face file name.

Paul Gofman pgofman at codeweavers.com
Thu Jan 14 07:55:34 CST 2021


Fixes crash in Shadow Empire during font initialization.

Signed-off-by: Paul Gofman <pgofman at codeweavers.com>
---
 dlls/gdi32/font.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/gdi32/font.c b/dlls/gdi32/font.c
index 7f243192cc3..6f50cc92a83 100644
--- a/dlls/gdi32/font.c
+++ b/dlls/gdi32/font.c
@@ -913,7 +913,7 @@ static BOOL insert_face_in_family_list( struct gdi_font_face *face, struct gdi_f
                    debugstr_w(face->full_name), debugstr_w(family->family_name),
                    cursor->version, face->version );
 
-            if (face->file && !wcsicmp( face->file, cursor->file ))
+            if (face->file && cursor->file && !wcsicmp( face->file, cursor->file ))
             {
                 cursor->refcount++;
                 TRACE("Font %s already in list, refcount now %d\n",
-- 
2.29.2




More information about the wine-devel mailing list