[PATCH 1/5] user32/tests: Fix a test failure on w7u_2qxl TestBot VM.

Zhiyi Zhang zzhang at codeweavers.com
Thu Jan 21 04:15:16 CST 2021


Signed-off-by: Zhiyi Zhang <zzhang at codeweavers.com>
---
Fix test failures like https://test.winehq.org/data/a952453888fb5df3c70edf357820bc924b4f3e7f/win7_newtb-w7u-2qxl/user32:monitor.html

 dlls/user32/tests/monitor.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/dlls/user32/tests/monitor.c b/dlls/user32/tests/monitor.c
index 5e4cc9d154f..a23500de4d6 100644
--- a/dlls/user32/tests/monitor.c
+++ b/dlls/user32/tests/monitor.c
@@ -743,17 +743,18 @@ static void test_ChangeDisplaySettingsEx(void)
         {
             dm.dmPosition = position;
             dm.dmFields |= DM_POSITION;
-            res = ChangeDisplaySettingsExA(devices[device].name, &dm, NULL, CDS_RESET, NULL);
             /* Reattach detached non-primary adapters, otherwise ChangeDisplaySettingsExA with only CDS_RESET fails */
             if (mode == 0 && device)
             {
-                todo_wine ok(res == DISP_CHANGE_FAILED, "ChangeDisplaySettingsExA %s mode %d returned unexpected %d\n",
-                        devices[device].name, mode, res);
                 res = ChangeDisplaySettingsExA(devices[device].name, &dm, NULL, CDS_UPDATEREGISTRY | CDS_NORESET, NULL);
                 ok(res == DISP_CHANGE_SUCCESSFUL, "ChangeDisplaySettingsExA %s mode %d returned unexpected %d\n",
                         devices[device].name, mode, res);
                 res = ChangeDisplaySettingsExA(NULL, NULL, NULL, 0, NULL);
             }
+            else
+            {
+                res = ChangeDisplaySettingsExA(devices[device].name, &dm, NULL, CDS_RESET, NULL);
+            }
 
             ok(res == DISP_CHANGE_SUCCESSFUL ||
                     broken(res == DISP_CHANGE_FAILED), /* TestBots using VGA driver can't change to some modes */
-- 
2.27.0




More information about the wine-devel mailing list