[PATCH] kernelbase: Fix the fallback value in GetConsole*CP

Martin Storsjö martin at martin.st
Tue Jan 26 08:09:19 CST 2021


On Tue, 26 Jan 2021, Martin Storsjo wrote:

> This fixes a regression from 3576258402f5e23ad059cf446eafef7fb2c10430,
> where the fallback value (if no console is available, e.g. if
> stdin is piped from /dev/null) ends up as zero, instead of at OEM CP
> (as it was before 3576258402f5e23ad059cf446eafef7fb2c10430).
>
> Signed-off-by: Martin Storsjo <martin at martin.st>
> ---
> dlls/kernelbase/console.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

It was concluded on irc that this patch is wrong (and that this would 
break tests under kernel32, although the testbot only ran tests under 
kernelbase), and that this is supposed to return 0 (aka ACP) in this case.

// Martin




More information about the wine-devel mailing list