[PATCH 4/6] ntoskrnl.exe/tests: Add some HidD_GetFeature tests.
Rémi Bernon
rbernon at codeweavers.com
Fri Jul 2 04:04:07 CDT 2021
Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>
---
dlls/ntoskrnl.exe/tests/driver_hid.c | 21 ++++++++++++
dlls/ntoskrnl.exe/tests/ntoskrnl.c | 49 ++++++++++++++++++++++++++++
2 files changed, 70 insertions(+)
diff --git a/dlls/ntoskrnl.exe/tests/driver_hid.c b/dlls/ntoskrnl.exe/tests/driver_hid.c
index 793b25f3189..ae039c061de 100644
--- a/dlls/ntoskrnl.exe/tests/driver_hid.c
+++ b/dlls/ntoskrnl.exe/tests/driver_hid.c
@@ -403,6 +403,27 @@ static NTSTATUS WINAPI driver_internal_ioctl(DEVICE_OBJECT *device, IRP *irp)
break;
}
+ case IOCTL_HID_GET_FEATURE:
+ {
+ HID_XFER_PACKET *packet = irp->UserBuffer;
+ ULONG expected_size = 17;
+ ok(!in_size, "got input size %u\n", in_size);
+ ok(out_size == sizeof(*packet), "got output size %u\n", out_size);
+
+ todo_wine_if(packet->reportId == 0x5a || packet->reportId == 0xa5)
+ ok(packet->reportId == report_id, "got packet report id %u\n", packet->reportId);
+ todo_wine_if(packet->reportBufferLen == 16)
+ ok(packet->reportBufferLen >= expected_size, "got packet buffer len %u, expected %d or more\n",
+ packet->reportBufferLen, expected_size);
+ ok(!!packet->reportBuffer, "got packet buffer %p\n", packet->reportBuffer);
+
+ memset(packet->reportBuffer, 0xa5, 3);
+ if (report_id) ((char *)packet->reportBuffer)[0] = report_id;
+ irp->IoStatus.Information = 3;
+ ret = STATUS_SUCCESS;
+ break;
+ }
+
case IOCTL_HID_GET_STRING:
ok(!in_size, "got input size %u\n", in_size);
ok(out_size == 128, "got output size %u\n", out_size);
diff --git a/dlls/ntoskrnl.exe/tests/ntoskrnl.c b/dlls/ntoskrnl.exe/tests/ntoskrnl.c
index ee565a2fa47..84564de4c0e 100644
--- a/dlls/ntoskrnl.exe/tests/ntoskrnl.c
+++ b/dlls/ntoskrnl.exe/tests/ntoskrnl.c
@@ -2482,6 +2482,55 @@ static void test_hidp(HANDLE file, int report_id)
ok(report[0] == report_id, "got report[0] %02x, expected %02x\n", report[0], report_id);
+ memset(report, 0xcd, sizeof(report));
+ status = HidP_InitializeReportForID(HidP_Feature, report_id, preparsed_data, report, caps.FeatureReportByteLength);
+ ok(status == HIDP_STATUS_SUCCESS, "HidP_InitializeReportForID returned %#x\n", status);
+
+ SetLastError(0xdeadbeef);
+ ret = HidD_GetFeature(file, report, 0);
+ ok(!ret, "HidD_GetFeature succeeded\n");
+ todo_wine ok(GetLastError() == ERROR_INVALID_USER_BUFFER, "HidD_GetFeature returned error %u\n", GetLastError());
+
+ SetLastError(0xdeadbeef);
+ ret = HidD_GetFeature(file, report, caps.FeatureReportByteLength - 1);
+ todo_wine
+ ok(!ret, "HidD_GetFeature succeeded\n");
+ todo_wine
+ ok(GetLastError() == ERROR_INVALID_PARAMETER || broken(GetLastError() == ERROR_CRC),
+ "HidD_GetFeature returned error %u\n", GetLastError());
+
+ SetLastError(0xdeadbeef);
+ memset(buffer, 0x5a, sizeof(buffer));
+ ret = HidD_GetFeature(file, buffer, caps.FeatureReportByteLength);
+ if (report_id || broken(!ret))
+ {
+ todo_wine
+ ok(!ret, "HidD_GetFeature succeeded, last error %u\n", GetLastError());
+ todo_wine
+ ok(GetLastError() == ERROR_INVALID_PARAMETER || broken(GetLastError() == ERROR_CRC),
+ "HidD_GetFeature returned error %u\n", GetLastError());
+ }
+ else
+ {
+ ok(ret, "HidD_GetFeature failed, last error %u\n", GetLastError());
+ todo_wine ok(buffer[0] == 0x5a, "got buffer[0] %x, expected 0x5a\n", (BYTE)buffer[0]);
+ }
+
+ SetLastError(0xdeadbeef);
+ ret = HidD_GetFeature(file, report, caps.FeatureReportByteLength);
+ ok(ret, "HidD_GetFeature failed, last error %u\n", GetLastError());
+ todo_wine_if(!report_id)
+ ok(report[0] == report_id, "got report[0] %02x, expected %02x\n", report[0], report_id);
+
+ value = caps.FeatureReportByteLength * 2;
+ SetLastError(0xdeadbeef);
+ ret = sync_ioctl(file, IOCTL_HID_GET_FEATURE, NULL, 0, report, &value);
+ ok(ret, "IOCTL_HID_GET_FEATURE failed, last error %u\n", GetLastError());
+ todo_wine ok(value == 3, "got length %u, expected 3\n", value);
+ todo_wine_if(!report_id)
+ ok(report[0] == report_id, "got report[0] %02x, expected %02x\n", report[0], report_id);
+
+
HidD_FreePreparsedData(preparsed_data);
CloseHandle(file);
}
--
2.32.0
More information about the wine-devel
mailing list