[PATCH 1/2] user32: Allow the backends to defer restoring minimized windows.
Arkadiusz Hiler
ahiler at codeweavers.com
Fri Jul 2 08:57:06 CDT 2021
On Fri, Jul 02, 2021 at 08:19:57AM -0500, Marvin wrote:
> Hi,
>
> While running your changed tests, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
>
> Full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=93532
>
> Your paranoid android.
>
>
> === debiant2 (32 bit WoW report) ===
>
> user32:
> win.c:10376: Test failed: GetForegroundWindow() = 00000000
> win.c:10381: Test failed: Expected foreground window 00150128, got 00E400F2
> win.c:10383: Test failed: GetActiveWindow() = 00000000
> win.c:10383: Test failed: GetFocus() = 00000000
> win.c:10384: Test failed: Received WM_ACTIVATEAPP(1), did not expect it.
> win.c:10385: Test failed: Received WM_ACTIVATEAPP(0), did not expect it.
> win.c:10393: Test failed: Expected foreground window 00150128, got 00000000
> win.c:10395: Test failed: GetActiveWindow() = 00000000
> win.c:10395: Test failed: GetFocus() = 00000000
> win.c:10403: Test failed: Received WM_ACTIVATEAPP(1), did not expect it.
Those are just flaky tests. I was seeing anywhere between 3-17 failures
in user32 win tests during the development + I don't see how the change
in question could cause any of those.
A re-run on testbot and it looks clean: https://testbot.winehq.org/JobDetails.pl?Key=93534
--
Cheers,
Arek
More information about the wine-devel
mailing list