[PATCH 2/2] wined3d: Pass a wined3d_device pointer to wined3d_from_cs().

Giovanni Mascellani gmascellani at codeweavers.com
Tue Jul 6 08:32:32 CDT 2021


Il 05/07/21 14:28, Henri Verbeet ha scritto:
> Well, yes, it doesn't. Are you saying we need those here though?

I think so.

My understanding is that we are relying on undefined behavior, and I 
think we shouldn't do that, because it might break randomly at some 
point after unrelated changes, or with a different compiler; and it 
could result in a kind of bug that is very painful to debug.

I am not expert in compilers nor in this specific code, so I don't want 
to make an excessively strong opinion. But I think we might do a great 
favor to our future selves by avoiding the risk altogether.


More information about the wine-devel mailing list