[PATCH vkd3d v3 4/5] vkd3d-shader: Use struct vkd3d_bytecode_buffer in vkd3d_shader_serialize_root_signature().
Zebediah Figura (she/her)
zfigura at codeweavers.com
Tue Jul 6 14:12:42 CDT 2021
On 7/6/21 12:19 PM, Henri Verbeet wrote:
> On Mon, 5 Jul 2021 at 23:02, Zebediah Figura <zfigura at codeweavers.com> wrote:
>> libs/vkd3d-shader/dxbc.c | 374 +++++++++++----------------------------
>> 1 file changed, 105 insertions(+), 269 deletions(-)
> Conceptually I mostly like this, but it does change quite a bit of
> code at once; there would certainly be ways to split this, like first
> implementing the old helpers on top of the new ones, and then
> gradually replacing them. This also removes some compiler error
> messages. It may be fine to move/merge those (e.g. we could check for
> out of memory at the end of vkd3d_shader_serialize_root_signature()),
> but I don't think we want to remove them entirely.
The problem I see with the compiler error messages is that they
universally try to allocate more memory than we just failed to allocate.
I don't think it's possible for any of those messages to make it out in
one piece in the first place.
More information about the wine-devel