[PATCH v2 1/4] include: Add d2d1effects.idl with defines for D2D12DAffineTransform.

[Henri Verbeet]

On Thu, 8 Jul 2021 at 12:12, Ziqing Hui <zhui at codeweavers.com> wrote:
> diff --git a/include/Makefile.in b/include/Makefile.in
> index 61a74a210c9..138693c8907 100644
> --- a/include/Makefile.in
> +++ b/include/Makefile.in
> @@ -99,6 +99,7 @@ SOURCES = \
>         d2d1.idl \
>         d2d1_1.idl \
>         d2d1_2.idl \
> +    d2d1effects.idl \

That should use a (hard) tab like the other entries in the list. This
file is also automatically generated by tools/make_makefiles though,
so in a certain sense it's ok.

> +/* Built in effect CLSIDs */
> +cpp_quote("DEFINE_GUID(CLSID_D2D12DAffineTransform, 0x6aa97485,0x6354,0x4cfc,0x90,0x8c,0xe4,0xa7,0x4f,0x62,0xc9,0x6c);")
> +
That comment is a bit too similar to one in the PSDK header for my
taste. (And not especially useful to begin with.)

> +typedef enum D2D1_BORDER_MODE
> +{
> +    D2D1_BORDER_MODE_SOFT = 0,
> +    D2D1_BORDER_MODE_HARD = 1,
> +    D2D1_BORDER_MODE_FORCE_DWORD = 0xffffffff
> +} D2D1_BORDER_MODE;
> +
> +typedef enum D2D1_2DAFFINETRANSFORM_PROP
> +{
> +    D2D1_2DAFFINETRANSFORM_PROP_INTERPOLATION_MODE = 0,
> +    D2D1_2DAFFINETRANSFORM_PROP_BORDER_MODE = 1,
> +    D2D1_2DAFFINETRANSFORM_PROP_TRANSFORM_MATRIX = 2,
> +    D2D1_2DAFFINETRANSFORM_PROP_SHARPNESS = 3,
> +    D2D1_2DAFFINETRANSFORM_PROP_FORCE_DWORD = 0xffffffff
> +} D2D1_2DAFFINETRANSFORM_PROP;
> +
> +typedef enum D2D1_2DAFFINETRANSFORM_INTERPOLATION_MODE
> +{
> +    D2D1_2DAFFINETRANSFORM_INTERPOLATION_MODE_NEAREST_NEIGHBOR = 0,
> +    D2D1_2DAFFINETRANSFORM_INTERPOLATION_MODE_LINEAR = 1,
> +    D2D1_2DAFFINETRANSFORM_INTERPOLATION_MODE_CUBIC = 2,
> +    D2D1_2DAFFINETRANSFORM_INTERPOLATION_MODE_MULTI_SAMPLE_LINEAR = 3,
> +    D2D1_2DAFFINETRANSFORM_INTERPOLATION_MODE_ANISOTROPIC = 4,
> +    D2D1_2DAFFINETRANSFORM_INTERPOLATION_MODE_HIGH_QUALITY_CUBIC = 5,
> +    D2D1_2DAFFINETRANSFORM_INTERPOLATION_MODE_FORCE_DWORD = 0xffffffff
> +} D2D1_2DAFFINETRANSFORM_INTERPOLATION_MODE;

It doesn't end up making much of a difference here, but we tend to
specify enumeration values in hexadecimal in d2d1, since that's also
what we use in TRACEs.