[PATCH] user32: During destroy, don't send WM_ERASEBKGND to parent window if WS_CHILD is not set

Zebediah Figura (she/her) zfigura at codeweavers.com
Thu Jul 15 17:56:55 CDT 2021


Hello Andrew,

I don't think this is the right fix. Based on my tests, and bug 51140 
[1], I don't think we should be sending WM_ERASEBKGND even if the window 
does have WM_PARENT. E.g. the attached patch on top of your tests works 
on my Windows machine, but still fails on Wine.

When I tested it earlier I was unable to find a set of conditions where 
Windows does send WM_ERASEBKGND to the parent of a hidden window, but I 
didn't want to just remove that code without re-debugging bug 6006 [2].

ἔρρωσο,
Zebediah

[1] https://bugs.winehq.org/show_bug.cgi?id=51140

[2] https://bugs.winehq.org/show_bug.cgi?id=6006
-------------- next part --------------
A non-text attachment was scrubbed...
Name: scratch.diff
Type: text/x-patch
Size: 1542 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20210715/4e5ce193/attachment.bin>


More information about the wine-devel mailing list