[PATCH] kernel32/tests: Allow failure when loading the 268 bytes minimal PE image.
Dmitry Timoshkov
dmitry at baikal.ru
Fri Jul 16 10:51:17 CDT 2021
Francois Gouget <fgouget at codeweavers.com> wrote:
> - /* Minimal PE image that Windows7 is able to load: 268 bytes */
> + /* Minimal PE image that Windows Vista is able to load: 268 bytes */
> { 0x04,
> 0, 0xf0, /* optional header size just forces 0xf0 bytes to be written,
> 0 or another number don't change the behaviour, what really
> matters is file size regardless of values in the headers */
> 0x04 /* also serves as e_lfanew in the truncated MZ header */, 0x04,
> - 0x40, /* minimal image size that Windows7 accepts */
> + 0x40, /* minimal image size that Vista accepts */
> 0,
> - { ERROR_SUCCESS }
> + { ERROR_SUCCESS, ERROR_BAD_EXE_FORMAT } /* most win 7+ are more strict */
I have created this test under Windows 7, so at that time this definitely
worked. While I'm not opposed to add ERROR_BAD_EXE_FORMAT as a fallback
error value, I do oppose to changing in the comment Windows7 to Vista,
Vista is an utterly broken platform in many aspects, promoting its name
to a not related test result is not fair.
--
Dmitry.
More information about the wine-devel
mailing list