[PATCH] kernel32/tests: Allow failure when loading the 268 bytes minimal PE image.

Dmitry Timoshkov dmitry at baikal.ru
Sun Jul 18 08:59:51 CDT 2021

François Gouget <fgouget at free.fr> wrote:

> On Fri, 16 Jul 2021, Dmitry Timoshkov wrote:
> [...]
> > I have created this test under Windows 7, so at that time this definitely
> > worked. While I'm not opposed to add ERROR_BAD_EXE_FORMAT as a fallback
> > error value, I do oppose to changing in the comment Windows7 to Vista,
> > Vista is an utterly broken platform in many aspects, promoting its name
> > to a not related test result is not fair.
> WTH???
> Where do you see Vista being promoted?
> What the heck is this thing about fairness?
> What do your likes and dislikes have to do with the accuracy of the 
> comment?

What I meant by using the word "promoting" is simply the fact of changing
original meaning that the test represents Windows 7 behaviour, and that
using Vista in that context is not appropriate. I addition, at the time
the test was submitted and accepted, it did successfully pass under the
testbot VMs. Since you are the testbot maintainer, and were maintaining
testbot also in the time frame when this test was committed, I'd guess
it's the question to you, what changed since then that the test no longer

If you can't for some reason stay in bounds, please refrain from sending
offensive posts, of course if your original intent is not to be ignored.


More information about the wine-devel mailing list