[PATCH] user32/tests: Remove the todo_wine from a test that succeeds in Wine.

Zebediah Figura (she/her) zfigura at codeweavers.com
Sun Jul 18 12:05:35 CDT 2021


On 7/18/21 1:56 AM, Francois Gouget wrote:
> Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
> ---
> At least it does succeed in Wine on the TestBot VMs and the cw-gtx560
> and cw-rx460 machines. Maybe it fails on some other machines?
> It even succeeds on my box (KDE) though not always and sometimes the
> following 'ShowWindow(SW_SHOWMINIMIZED):overlapped' test fails instead.
> ---
>   dlls/user32/tests/msg.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c
> index 9867e319d58..b5228f8facb 100644
> --- a/dlls/user32/tests/msg.c
> +++ b/dlls/user32/tests/msg.c
> @@ -5405,7 +5405,7 @@ static void test_messages(void)
>   
>       ShowWindow(hwnd, SW_MINIMIZE);
>       flush_events();
> -    ok_sequence(WmShowMinOverlappedSeq, "ShowWindow(SW_SHOWMINIMIZED):overlapped", TRUE);
> +    ok_sequence(WmShowMinOverlappedSeq, "ShowWindow(SW_SHOWMINIMIZED):overlapped", FALSE);
>       flush_sequence();
>   
>       if (GetWindowLongW( hwnd, GWL_STYLE ) & WS_MINIMIZE)
> 

This is the fourth (?) time someone's tried to "fix" this test:

https://www.winehq.org/pipermail/wine-devel/2019-May/146432.html

We've also had three attempts to actually fix the code, at least one of 
which was resent, all of which fell off the list without review:

https://www.winehq.org/pipermail/wine-devel/2018-January/121877.html

https://www.winehq.org/pipermail/wine-devel/2020-March/161044.html



More information about the wine-devel mailing list