[PATCH 3/3] d2d1/tests: Add tests for standard effect properties.

[Giovanni Mascellani]

Hi,

Il 21/07/21 12:02, Ziqing Hui ha scritto:
> +    const WCHAR *expected_author = L"Microsoft Corporation";
> +    const struct effect_test
> +    {
> +        const CLSID *clsid;
> +        const WCHAR *name;
> +        const WCHAR *category;
> +        UINT32 min_inputs;
> +        UINT32 max_inputs;
> +        const WCHAR *description;
> +    }
> +    effect_tests[] =
> +    {
> +        /* 0: 2D Affine Transform */
> +        {
> +            &CLSID_D2D12DAffineTransform,      L"2D Affine Transform",      L"Transform", 1, 1,
> +            L"Applies a 2D affine transform to a bitmap.",
> +        },
> +        /* 1: 3D Perspective Transform */
> +        {
> +            &CLSID_D2D13DPerspectiveTransform, L"3D Perspective Transform", L"Transform", 1, 1,
> +            L"Applies a 3D perspective transform to a bitmap."
> +        },
> +        /* 2: Composite */
> +        {
> +            &CLSID_D2D1Composite,              L"Composite",                L"Composite", 1, 0xffffffff,
> +            L"Composites foreground and background images using the selected composition mode."
> +        }
> +    };
> +

Hmm, is it a good idea to add the precise Windows strings to Wine? It 
might be a violation of copyright. Unless there are application that 
really depend on those exact strings, I wouldn't strive to replicate 
them exactly (and, correspondingly, I wouldn't check them exactly). 
Also, I would avoid mentioning Microsoft as the author, given that it's 
not. Again, unless there is some application really depending on this, 
which at least would give as an argument to have the same strings (as I 
get it, compatibility can be, in some jurisdictions, a good reason for 
"breaking" copyright).

> +        if (PRIMARYLANGID(GetSystemDefaultLangID()) == LANG_ENGLISH)
> +        {

There are some tests that do not depend on the system language (clsid, 
cached, precision, input counts, if I am not mistaken).  Those tests 
should be run even if the language is not set to English.

Thanks, Giovanni.