[PATCH 2/2] conhost: Popup Attributes should match Character Attributes when a new screen buffer is created

Jacek Caban jacek at codeweavers.com
Fri Jul 23 07:23:51 CDT 2021

Hi Hugh,

On 7/22/21 3:36 PM, Hugh McMaster wrote:
> @@ -104,6 +104,7 @@ static struct screen_buffer *create_screen_buffer( struct console *console, int
>           screen_buffer->win.right  = width - 1;
>           screen_buffer->win.bottom = height - 1;
>           screen_buffer->attr       = FOREGROUND_BLUE|FOREGROUND_GREEN|FOREGROUND_RED;
> +        screen_buffer->popup_attr = screen_buffer->attr;

This part doesn't seem right. For windowed consoles this part is 
overwritten when we read the config, but it's not the case for pseudo 
consoles (or when we use Unix console). This breaks the attached test.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: test.diff
Type: text/x-patch
Size: 1426 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20210723/3ef3a518/attachment.bin>

More information about the wine-devel mailing list