[PATCH vkd3d] vkd3d: Use correct enumeration type. (Clang)
hverbeet at gmail.com
Mon Jul 26 10:44:43 CDT 2021
On Fri, 23 Jul 2021 at 01:36, Chip Davis <cdavis at codeweavers.com> wrote:
> July 22, 2021 4:15 AM, "Henri Verbeet" <hverbeet at gmail.com> wrote:
> > On Tue, 20 Jul 2021 at 20:24, Chip Davis <cdavis at codeweavers.com> wrote:
> >> libs/vkd3d/command.c | 26 +++++++++++++-------------
> >> 1 file changed, 13 insertions(+), 13 deletions(-)
> > I'm tempted to just sign off on this because it's an otherwise trivial
> > patch, but that commit message is very poor.
> What would you suggest instead? Something like, "vkd3d: Fix enum conversion warnings. (Clang)", perhaps?
As a rule of thumb, I'd suggest being specific about what the patch
changes. In this particular case, perhaps something like "vkd3d: Pass
vkd3d_pipeline_bind_point values to
d3d12_command_list_update_descriptors() calls." That would require
splitting the patch for the different functions it affects, but I
don't think that's a bad thing.
More information about the wine-devel