[PATCH v2] msvcrt: Make the cosh/sinh/tanh functions NAN preserving

Martin Storsjö martin at martin.st
Mon Jul 26 16:41:43 CDT 2021


On Fri, 16 Jul 2021, Zebediah Figura (she/her) wrote:

> On 7/16/21 7:05 AM, Martin Storsjo wrote:
>> When a NAN is fed as input, return it as-is without mangling
>> it through the calculation (which e.g. loses the sign of the
>> input value).
>> 
>> This fixes a regression in a testcase of mine, after switching
>> to the internal implementation of these functions.
>
> Maybe we could add such tests to Wine as well?

Yeah I guess that's best. I had set out hoping this would be trivial 
enough to work without, but it turned out to be quite a bit more fiddly 
than I first expected.

// Martin




More information about the wine-devel mailing list