[PATCH vkd3d 3/7] vkd3d: Return E_INVALIDARG if a descriptor range overflows.
Conor McCarthy
cmccarthy at codeweavers.com
Thu Jul 29 23:03:16 CDT 2021
Signed-off-by: Conor McCarthy <cmccarthy at codeweavers.com>
---
libs/vkd3d/state.c | 3 +++
tests/d3d12.c | 3 ---
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/libs/vkd3d/state.c b/libs/vkd3d/state.c
index d62cb9a0..46804883 100644
--- a/libs/vkd3d/state.c
+++ b/libs/vkd3d/state.c
@@ -613,6 +613,9 @@ static HRESULT d3d12_root_signature_init_root_descriptor_tables(struct d3d12_roo
if (range->OffsetInDescriptorsFromTableStart != D3D12_DESCRIPTOR_RANGE_OFFSET_APPEND)
offset = range->OffsetInDescriptorsFromTableStart;
+ if (offset + range->NumDescriptors < offset)
+ return E_INVALIDARG;
+
table->ranges[j].offset = offset;
table->ranges[j].descriptor_count = range->NumDescriptors;
table->ranges[j].descriptor_magic = vkd3d_descriptor_magic_from_d3d12(range->RangeType);
diff --git a/tests/d3d12.c b/tests/d3d12.c
index a03cb965..95792926 100644
--- a/tests/d3d12.c
+++ b/tests/d3d12.c
@@ -2868,10 +2868,7 @@ static void test_root_signature_limits(void)
descriptor_ranges[0].NumDescriptors = 0x1001;
descriptor_ranges[0].OffsetInDescriptorsFromTableStart = 0xFFFFF000;
hr = create_root_signature(device, &root_signature_desc, &root_signature);
- todo
ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr);
- if (SUCCEEDED(hr))
- ID3D12RootSignature_Release(root_signature);
refcount = ID3D12Device_Release(device);
ok(!refcount, "ID3D12Device has %u references left.\n", (unsigned int)refcount);
--
2.32.0
More information about the wine-devel
mailing list