[PATCH vkd3d v2 3/4] vkd3d: Write Vulkan descriptor sets containing arrayed bindings.
Conor McCarthy
cmccarthy at codeweavers.com
Thu Jun 3 00:04:06 CDT 2021
Signed-off-by: Conor McCarthy <cmccarthy at codeweavers.com>
---
libs/vkd3d/command.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/libs/vkd3d/command.c b/libs/vkd3d/command.c
index 06d7746d..dbbe822a 100644
--- a/libs/vkd3d/command.c
+++ b/libs/vkd3d/command.c
@@ -2592,7 +2592,7 @@ static void d3d12_command_list_prepare_descriptors(struct d3d12_command_list *li
static bool vk_write_descriptor_set_from_d3d12_desc(VkWriteDescriptorSet *vk_descriptor_write,
VkDescriptorImageInfo *vk_image_info, const struct d3d12_desc *descriptor,
uint32_t descriptor_range_magic, VkDescriptorSet vk_descriptor_set,
- uint32_t vk_binding, unsigned int index)
+ uint32_t vk_binding, unsigned int index, bool bindless)
{
const struct vkd3d_view *view = descriptor->u.view;
@@ -2602,8 +2602,10 @@ static bool vk_write_descriptor_set_from_d3d12_desc(VkWriteDescriptorSet *vk_des
vk_descriptor_write->sType = VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET;
vk_descriptor_write->pNext = NULL;
vk_descriptor_write->dstSet = vk_descriptor_set;
- vk_descriptor_write->dstBinding = vk_binding + index;
- vk_descriptor_write->dstArrayElement = 0;
+ /* If bindless is true the descriptors use a single array binding. The value of
+ * range->descriptor_count is not necessarily UINT_MAX in this case. */
+ vk_descriptor_write->dstBinding = bindless ? vk_binding : vk_binding + index;
+ vk_descriptor_write->dstArrayElement = bindless ? index : 0;
vk_descriptor_write->descriptorCount = 1;
vk_descriptor_write->descriptorType = descriptor->vk_descriptor_type;
vk_descriptor_write->pImageInfo = NULL;
@@ -2620,7 +2622,8 @@ static bool vk_write_descriptor_set_from_d3d12_desc(VkWriteDescriptorSet *vk_des
case VKD3D_DESCRIPTOR_MAGIC_UAV:
/* We use separate bindings for buffer and texture SRVs/UAVs.
* See d3d12_root_signature_init(). */
- vk_descriptor_write->dstBinding = vk_binding + 2 * index;
+ if(!bindless)
+ vk_descriptor_write->dstBinding = vk_binding + 2 * index;
if (descriptor->vk_descriptor_type != VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER
&& descriptor->vk_descriptor_type != VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER)
++vk_descriptor_write->dstBinding;
@@ -2707,7 +2710,7 @@ static void d3d12_command_list_update_descriptor_table(struct d3d12_command_list
if (!vk_write_descriptor_set_from_d3d12_desc(current_descriptor_write,
current_image_info, descriptor, range->descriptor_magic,
- bindings->descriptor_set, range->binding, j))
+ bindings->descriptor_set, range->binding, j, root_signature->bindless))
continue;
++descriptor_count;
--
2.31.1
More information about the wine-devel
mailing list