[PATCH v2 3/6] ntoskrnl.exe/tests: Use HID helper macros to write report descriptors.

Rémi Bernon rbernon at codeweavers.com
Thu Jun 3 10:46:00 CDT 2021


On 6/3/21 5:42 PM, Zebediah Figura (she/her) wrote:
> I meant to offer this comment on the patches already committed, but 
> maybe instead of having an extra file to #undef everything, we could 
> just prepend HID_ to all of the definitions and leave them defined?
> 

It's just making everything much more verbose, especially for INPUT / 
OUTPUT / FEATURE attributes (and IMHO much more horrible to read).

Not having the prefixes also makes it much easier to reproduce template 
HID reports that are used in the specifications as example reports.
-- 
Rémi Bernon <rbernon at codeweavers.com>



More information about the wine-devel mailing list