[PATCH 3/5] hid: Use nameless unions.

Rémi Bernon rbernon at codeweavers.com
Fri Jun 4 05:36:21 CDT 2021


On 6/4/21 12:21 PM, Marvin wrote:
> Hi,
> 
> While running your changed tests, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
> 
> Full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=91885
> 
> Your paranoid android.
> 
> 
> === debiant2 (32 bit report) ===
> 
> hid:
> device: Timeout
> 

I think this is caused by empty mouse / keyboard HID input report 
descriptors.

This causes winedevice to crash on my machine (because it's trying to 
write at least the report id to an empty buffer passed to the ioctl),
and it should probably check the available size and buffer.

We should also probably create non-empty input report descriptors for 
the dummy mouse and keyboard devices.

I'll send separate patches to fix these.
-- 
Rémi Bernon <rbernon at codeweavers.com>



More information about the wine-devel mailing list