[PATCH v3 6/6] ntoskrnl.exe/tests: Add some HidP_InitializeReportForID tests.

Rémi Bernon rbernon at codeweavers.com
Tue Jun 8 15:57:54 CDT 2021


On 6/8/21 10:50 PM, Zebediah Figura (she/her) wrote:
>> +    status = HidP_InitializeReportForID(HidP_Input, 0, 
>> preparsed_data, report, caps.InputReportByteLength);
>> +    ok(status == HIDP_STATUS_SUCCESS, "HidP_InitializeReportForID 
>> returned %#x\n", status);
>> +
>> +    memset(buffer, 0xcd, sizeof(buffer));
>> +    memset(buffer, 0, 5);
>> +    buffer[0] = 0;
> 
> This statement is redundant; is there a copy-paste error here?
> 

I was doing some tests with report IDs, and I'm going to add tests with 
it, it's probably some left over code from a version with an ID which I 
then set to 0.

I've got additional patches that will change that part again, so this 
patch can just be ignored and I'll make another version that better fits 
with the later changes.
-- 
Rémi Bernon <rbernon at codeweavers.com>



More information about the wine-devel mailing list