[PATCH] urlmon: Handle failure using HTTP Basic authentication scheme by asking user/password.

[Jacek Caban]

On 6/8/21 9:02 PM, Dmitry Timoshkov wrote:
> Hi Jacek,
>
> Jacek Caban <jacek at codeweavers.com> wrote:
>
>> On 6/7/21 6:39 PM, Dmitry Timoshkov wrote:
>>> +void handle_basic_auth_error(Protocol *prot)
>>> +{
>>> +    HttpProtocol *This = impl_from_Protocol(prot);
>>> +
>>> +    handle_http_error(This, ERROR_SUCCESS);
>>> +}
>>
>> Shouldn't we use IAuthenticate from bind status callback in this case?
> I'd appreciate some pointers how to implement this using BSC interface.


My understanding is that we should ask for IAuthenticate interface on 
BSC and let it handle the authentication. GUI asking for credentials is 
likely something that urlmon needs to do in response to some return 
values from Authenticate, but I don't know that without testing it 
myself. Then there is a question if MSHTML should implement 
IAuthenticate, but it may not matter in your case (depending on the 
answer to above).


If you didn't already, I would suggest to write a test and experiment. I 
know that tests involving GUI may not be something for the tree (well, 
unless in interactive mode), but maybe with testing IAuthenticate it 
would be possible to test the rest of the stack.


Thanks,

Jacek