[PATCH 2/2] mf: Reset END_OF_PRESENTATION flags after stopping the session.

Giovanni Mascellani gmascellani at codeweavers.com
Fri Jun 11 01:43:21 CDT 2021


Hi,

Il 11/06/21 08:04, Nikolay Sivov ha scritto:
> Just making sure, to reproduce this I need to let it play to the end,
> and then calling Start(0) doesn't replay?

Yes, you reproduce to the end, then restart with Start(0); the session 
restarts, but with the SESSION_FLAG_END_OF_PRESENTATION flag 
(incorrectly) set. This means, for example, that if you later call Close 
it will do the wrong thing for example at [1]. This ultimately leads at 
not delivering the MESessionClosed event, which causes a freeze in Deep 
Rock Galactic.

  [1] 
https://source.winehq.org/git/wine.git/blob/refs/heads/master:/dlls/mf/session.c#l2684

Giovanni.



More information about the wine-devel mailing list