[PATCH] msxml3: Null check url in parseURL.

Nikolay Sivov nsivov at codeweavers.com
Tue Jun 15 02:36:54 CDT 2021


> @@ -2745,6 +2745,8 @@ static HRESULT internal_parseURL(
>  
>      TRACE("(%p)->(%s)\n", This, debugstr_w(url));
>  
> +    if (!url) return E_INVALIDARG;
> +
>      hr = create_moniker_from_url(url, &mon);
>      if(FAILED(hr))
>          return hr;
This is used in IVB* interface too, which is not tested.

> +        /* crashes on new versions */
> +        if (IsEqualGUID(table->clsid, &CLSID_SAXXMLReader) ||
> +            IsEqualGUID(table->clsid, &CLSID_SAXXMLReader30)) {
> +            hr = ISAXXMLReader_parseURL(reader, NULL);
> +            EXPECT_HR(hr, E_INVALIDARG);
> +        }
> +
We might want to do the same, there is a 'version' field to account for
that.



More information about the wine-devel mailing list