[PATCH] urlmon: Handle failure using HTTP Basic authentication scheme by asking user/password.

[Jacek Caban]

On 6/16/21 5:53 PM, Dmitry Timoshkov wrote:
> Hi Jacek,
>
> Jacek Caban <jacek at codeweavers.com> wrote:
>
>> My understanding is that we should ask for IAuthenticate interface on
>> BSC and let it handle the authentication. GUI asking for credentials is
>> likely something that urlmon needs to do in response to some return
>> values from Authenticate, but I don't know that without testing it
>> myself. Then there is a question if MSHTML should implement
>> IAuthenticate, but it may not matter in your case (depending on the
>> answer to above).
>>
>>
>> If you didn't already, I would suggest to write a test and experiment. I
>> know that tests involving GUI may not be something for the tree (well,
>> unless in interactive mode), but maybe with testing IAuthenticate it
>> would be possible to test the rest of the stack.
> My current WIP patch with both interactive and non-interactive tests
> is attached, non-interactive tests pass, interactive ones - not yet.
> I'd appreciate any comments and suggestions.


The general approach seems reasonable to me. I would suggest to use 
test_BindToStorage() in tests, it's generally an easier code path (and 
parts that are present only in BindToObject() and not very interesting 
in this context).


Thanks,

Jacek