[PATCH v2] kernelbase: Don't pass on StdHandles if they are never to be inherited
Jacek Caban
jacek at codeweavers.com
Thu Jun 24 06:12:16 CDT 2021
On 6/24/21 5:10 AM, Brendan McGrath wrote:
>
> I updated the tests in the bug. I tested calling GUI and CUI exes as
> the child and with inherit set to FALSE and inherit set to TRUE.
>
> I also added output for the Teb and StartInfo structures - but the
> ANSI and Wide values were different. So I might modify the tests again
> to check what happens when I include the CREATE_UNICODE_ENVIRONMENT vs
> leaving it out.
>
> Hopefully I'm on the right track?
Yes, that's what I was looking for, thanks. I think it proves that we we
should never pass parent std handles when CREATE_NEW_CONSOLE is used,
regardless of inherit flag. In that case, your original patch modified
to not check inherit would look good to me.
Thanks,
Jacek
More information about the wine-devel
mailing list