[PATCH v4 2/2] mf/sar: Allow requesting more than a sample per period.

Giovanni Mascellani gmascellani at codeweavers.com
Fri Jun 25 01:56:34 CDT 2021


Hi,

Il 24/06/21 22:02, Nikolay Sivov ha scritto:
> Does attached patch work? All we need is to queue some frames, not too ,
> if buffer is always at least a period long, that will be okay, either
> 3/2 as in this example or just max_frames is fine. I'd like to keep it
> simple.

Yes, it works.

Personally I don't see how it is simpler than mine (the conversion 
between time and number of frames is completely straightforward and 
standard in this kind of processing), and I would find it confusing that 
the buffer size is used for something that has nothing to do with the 
buffer.

However, I guess the decision is up to you.

Giovanni.



More information about the wine-devel mailing list