[PATCH resend] winedbg: Try to load debug symbols for executable in gdb mode.

[Bernhard Übelacker]

Am 25.06.21 um 16:26 schrieb Alexandre Julliard:
> Bernhard Übelacker <bernhardu at mailbox.org> writes:
> 
>> diff --git a/programs/winedbg/gdbproxy.c b/programs/winedbg/gdbproxy.c
>> index 478e0d16fe0..d768a8a585c 100644
>> --- a/programs/winedbg/gdbproxy.c
>> +++ b/programs/winedbg/gdbproxy.c
>> @@ -437,6 +437,17 @@ static BOOL handle_debug_event(struct gdb_context* gdbctx)
>>           fprintf(stderr, "%04x:%04x: create thread I @%p\n", de->dwProcessId,
>>               de->dwThreadId, de->u.CreateProcessInfo.lpStartAddress);
>>   
>> +        fetch_module_name( de->u.CreateProcessInfo.lpImageName, de->u.CreateProcessInfo.lpBaseOfImage,
>> +                           u.buffer, ARRAY_SIZE(u.buffer) );
>> +        fprintf(stderr, "%04x:%04x: loads EXE %s @%p (%u<%u>)\n",
>> +                de->dwProcessId, de->dwThreadId,
>> +                dbg_W2A(u.buffer, -1),
>> +                de->u.CreateProcessInfo.lpBaseOfImage,
>> +                de->u.CreateProcessInfo.dwDebugInfoFileOffset,
>> +                de->u.CreateProcessInfo.nDebugInfoSize);
> 
> None of that should be necessary, it looks like you are copying some old
> code.


I copied this from the LOAD_DLL_DEBUG_EVENT a few lines below.

But yes, the fetch_module_name for the CREATE_PROCESS_DEBUG_EVENT is
not necessary, the lpBaseOfImage is already filled.

The "loads EXE" is also just a copy of the "loads DLL" line
printed for each dll.

I will send a new version with both removed. Thanks for the review.

Kind regards,
Bernhard