[PATCH] d3dx9: Implement D3DXComputeTangent().

Zebediah Figura (she/her) zfigura at codeweavers.com
Tue Mar 2 10:31:58 CST 2021


On 3/2/21 1:27 AM, Matteo Bruni wrote:
> A rare occasion where I can quote myself recursively, so I'll do just
> that: https://www.winehq.org/pipermail/wine-devel/2019-April/143293.html
> 
> While it would be nice to have some nice and detailed tests along the
> lines of mesh.c:test_compute_normals(), I'll settle for the minimum
> necessary to confirm that the arguments to D3DXComputeTangentFrameEx()
> are correct (or otherwise, e.g. if that can't be tested for whatever
> reason, a small comment in the code).
> 

Yeah, sorry, I missed that somehow.

The reason (which I should probably have mentioned regardless) I didn't
write tests is that, as far as I can tell, the actual functionality of
D3DXComputeTangent() isn't implemented. I could probably address that
too, though...

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20210302/acbfa7ff/attachment-0001.sig>


More information about the wine-devel mailing list