[PATCH v2] dwrite: Do not segfault when there are no typographic features to return.

Giovanni Mascellani gmascellani at codeweavers.com
Wed Mar 3 08:17:04 CST 2021


Il 03/03/21 14:42, Nikolay Sivov ha scritto:
> 'tags' would be null if count is 0

My philosophy here is that tags being NULL is just an artifact of 
implementation; if the code working with that struct changes, it might 
happen that count is zero, but tags is not NULL, so in the future it 
might happen that changes in another function makes this one buggy, 
which would be nice to avoid. To me, if an object is initialized, then 
it should be properly destructed, without assuming which code path it 
will have gone though by the time it is destructed.

However, no problem removing that line. Ack for the rest, will submit 
another version.

Giovanni.




More information about the wine-devel mailing list