[PATCH 1/4] windows.media.speech: Add stub dll.

[Rémi Bernon]

On 3/4/21 12:58 PM, Jacek Caban wrote:
> Hi Rémi,
> 
> 
> On 04/03/2021 09:29, Rémi Bernon wrote:
>> Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>
>> ---
>>
>> This DLL is required to run Microsoft Flight Simulator.
>>
>>   configure.ac                                  |   1 +
>>   dlls/windows.media.speech.dll/Makefile.in     |   5 +
>>   .../windows.media.speech.spec                 |   3 +
>>   .../windows.media.speech_main.c               | 140 ++++++++++++++++++
> 
> 
> I think that shorter C file names would be nicer.
> 
> 
>> diff --git a/dlls/windows.media.speech.dll/windows.media.speech_main.c 
>> b/dlls/windows.media.speech.dll/windows.media.speech_main.c
>> new file mode 100644
>> index 00000000000..c7c14deef78
>> --- /dev/null
>> +++ b/dlls/windows.media.speech.dll/windows.media.speech_main.c
>> @@ -0,0 +1,140 @@
>> +#include <stdarg.h>
>> +
>> +#define COBJMACROS
>> +#include "windef.h"
>> +#include "winbase.h"
>> +#include "winstring.h"
>> +#include "wine/debug.h"
>> +#include "objbase.h"
> 
> 
> A copyright header is missing.
> 

Of course.

> 
>> diff --git a/loader/wine.inf.in b/loader/wine.inf.in
>> index d5dd2d5b66b..db816327a51 100644
>> --- a/loader/wine.inf.in
>> +++ b/loader/wine.inf.in
>> @@ -713,6 +713,7 @@ HKLM,%MciExtStr%,"wmx",,"MPEGVideo"
>>   HKLM,%MciExtStr%,"wvx",,"MPEGVideo"
>>   [Misc]
>> +HKLM,Software\Microsoft\WindowsRuntime\ActivatableClassId\Windows.Media.SpeechSynthesis.SpeechSynthesizer,"DllPath",2,"Windows.Media.Speech.dll" 
>>
>>   HKLM,Software\Borland\Database 
>> Engine\Settings\SYSTEM\INIT,SHAREDMEMLOCATION,,9000
>>   HKLM,Software\Clients\Mail,,2,"Native Mail Client"
>>   HKLM,Software\Clients\Mail\Native Mail Client,,2,"Native Mail Client"
> 
> 
> You could achieve the same with a local .rgs file. Ultimately, it looks 
> like a job for widl to generate .rgs files like we do for regular COM 
> objects.
> 

Nice, I didn't know about the rgs files!

How would WIDL know which class is actually implemented in the DLL and 
from which IDL?

> 
> Thanks,
> 
> Jacek
> -- 
Rémi Bernon <rbernon at codeweavers.com>