[tools] testbot/LogUtils: Don't close nonexistent test units.

Francois Gouget fgouget at codeweavers.com
Thu Mar 4 06:55:21 CST 2021


Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
This shouldn't really happen unless there is a bug that prevents 
ParseWineTestReport() from recognizing the initial start line (which is 
of course what happened). At least this makes it consistent with the 
other _CloseTestUnit() call.
---
 testbot/lib/WineTestBot/LogUtils.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testbot/lib/WineTestBot/LogUtils.pm b/testbot/lib/WineTestBot/LogUtils.pm
index 4d2619ccc..0bd7d19de 100644
--- a/testbot/lib/WineTestBot/LogUtils.pm
+++ b/testbot/lib/WineTestBot/LogUtils.pm
@@ -683,7 +683,7 @@ sub ParseWineTestReport($$$)
         # First close the current test unit taking into account
         # it may have been polluted by the new one.
         $Cur->{IsBroken} = 1;
-        _CloseTestUnit($LogInfo, $Cur, 0);
+        _CloseTestUnit($LogInfo, $Cur, 0) if ($Cur->{Dll} ne "");
 
         # Then switch to the new test unit, not for the past lines, but for
         # those before the next 'start' line. This 'new' test unit may have
-- 
2.20.1



More information about the wine-devel mailing list