[PATCH 02/11] ddraw/tests: Do not mark alternative results as broken in test_rt_caps() for ddraw7.

Henri Verbeet hverbeet at gmail.com
Fri Mar 5 12:36:22 CST 2021


On Wed, 3 Mar 2021 at 23:36, Paul Gofman <pgofman at codeweavers.com> wrote:
> @@ -6419,10 +6419,8 @@ static void test_rt_caps(const GUID *device_guid)
>              expected_caps = test_data[i].caps_out[software_device]
>                      ? test_data[i].caps_out[software_device] : test_data[i].caps_out[0];
>
> -            todo_wine_if(test_data[i].caps_out[software_device]
> -                    && surface_desc.ddsCaps.dwCaps == test_data[i].caps_out[0])
>              ok(surface_desc.ddsCaps.dwCaps == expected_caps
> -                    || broken(surface_desc.ddsCaps.dwCaps == test_data[i].caps_out[0]),
> +                    || surface_desc.ddsCaps.dwCaps == test_data[i].caps_out[0],
>                      "Got unexpected caps %#x, test %u, software_device %u.\n",
>                      surface_desc.ddsCaps.dwCaps, i, software_device);
>          }
Does that mean we want Wine to return these alternative results in
some conditions? I.e., more than making a judgement about what's right
and proper, broken() distinguishes results we want want Wine to return
from results we don't want Wine to return. If yes, under what
conditions do we want Wine to return these?



More information about the wine-devel mailing list